[sfputil-plugins] add tx_disable support for QSFP on fishbone/phalanx #65
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiantianlv
approved these changes
Mar 28, 2019
bbinxie
pushed a commit
that referenced
this pull request
May 8, 2020
[configdb.py]: Allow deletion of entire table from mod_config API. (#61) [MultiDB] mimic redis-dump-load , adding sonic_db_dump_load.py and so… [MultiDB] add sonic-db-cli PING all instances support (#65) Fix sonic-db-cli script to be compatible with python3 and python2.7 (#66) Namespace support in SonicV2Connector (#63) [Multiasic]: Add calculation of interface index for backplane interfa…
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- What I did
Update tx_disable() method in Fishbones and Phalanx to support QSFP port type.
- How I did it
For QSFP port type, use control function address 86, page A0h to set TX_DISABLE signals.
FOr SFP port type, use the TX_DISBLE hardware pin control.
- How to verify it
Create a test script to call the SfpUtil.tx_disable() method
Check corresponding sfp_txdisable file(for SFP) / control function byte data(for QSFP) to confirm status change.
- Description for the changelog
- A picture of a cute animal (not mandatory but encouraged)