Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Send and Sync implementations on Id and WeakId #8

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix Send and Sync implementations on Id and WeakId #8

wants to merge 2 commits into from

Commits on Jun 15, 2021

  1. Correct Send and Sync implementations on Id 

    See comments in the code for reasoning.

The impl for `Id<T, Shared>` is the same as `Arc<T>` and the impl for `Id<T, Owned>` is the same as `Box<T>`.
    @madsmtm
    madsmtm committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    0d5eac6 View commit details
    Browse the repository at this point in the history

  2. Correct Send and Sync implementations on WeakId 

    The implementations follow the same reasoning as `Id<T, Shared>`, since you can upgrade `WeakId` to `Id<T, Shared>`.
    @madsmtm
    madsmtm committed Jun 15, 2021
    Configuration menu
    Copy the full SHA
    8833c22 View commit details
    Browse the repository at this point in the history