feat: eda filter by column #1217
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-click-improvements
& fix: dont open new context menu if $prevent clicks and currentMenu open not already the same one, thus allowing repositioning of same context menu
…-click-improvements
…refresh-outdated-view
…-click-improvements
…refresh-outdated-view
…into 1216-eda-filter-by-column
|
@lars-reimann all should be good to go now! |
|
I know this last push fits more on the the other PR but was coding on this and then noticed on other branch there are conflicts, so just pushed here. |
…1216-eda-filter-by-column
|
@lars-reimann this should be ready to merge! |
|
@SmiteDeluxe Please take a look at the linter failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1216
Summary of Changes
Can now filter rows by columns.
Filters update and retain state. Profiling gets outdated depending on if current History state has profiling. Can get refreshed (that runner method inefficient since calling runner 3 times but not enough time). Tabs get set to outdated appropriately.
WARNING: Includes all other pending PRs, approve those first.