Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: first iteration of the purity data model and purity analysis #76

Merged
merged 46 commits into from
Mar 30, 2023

Conversation

lukarade
Copy link
Contributor

@lukarade lukarade commented Mar 27, 2023

Closes #5

Summary of Changes

Added the first iteration of the purity data model and the purity analysis. The analysis is capable of analyzing the purity of simple function definitions, as well as functions that interact with files.

Testing Instructions

run test_infer_purity

@lukarade lukarade linked an issue Mar 27, 2023 that may be closed by this pull request
@lukarade lukarade changed the title Draft: first iteration of the purity data model and purity analysis feat: first iteration of the purity data model and purity analysis Mar 27, 2023
@lars-reimann
Copy link
Member

lars-reimann commented Mar 27, 2023

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 6 0 0 0.88s
✅ PYTHON flake8 6 0 0.5s
✅ PYTHON isort 6 0 0 0.27s
✅ PYTHON mypy 6 0 2.37s
✅ PYTHON pylint 6 0 5.32s
✅ REPOSITORY git_diff yes no 0.04s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

@lars-reimann
Copy link
Member

@lukarade I pushed a fix that should resolve some test failures.

@codecov
Copy link

codecov bot commented Mar 28, 2023

Codecov Report

Merging #76 (38a06c8) into main (fd6a0f5) will increase coverage by 0.26%.
The diff coverage is 91.76%.

@@            Coverage Diff             @@
##             main      #76      +/-   ##
==========================================
+ Coverage   87.66%   87.92%   +0.26%     
==========================================
  Files          83       85       +2     
  Lines        3842     4107     +265     
==========================================
+ Hits         3368     3611     +243     
- Misses        474      496      +22     
Impacted Files Coverage Δ
...c/library_analyzer/processing/api/model/_purity.py 88.76% <88.76%> (ø)
...c/library_analyzer/processing/api/_infer_purity.py 93.10% <93.10%> (ø)
src/library_analyzer/processing/api/__init__.py 100.00% <100.00%> (ø)
.../library_analyzer/processing/api/model/__init__.py 100.00% <100.00%> (ø)
src/library_analyzer/utils/_ASTWalker.py 97.22% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@lukarade lukarade marked this pull request as ready for review March 29, 2023 17:07
@lukarade lukarade requested a review from a team as a code owner March 29, 2023 17:07
@lars-reimann lars-reimann marked this pull request as draft March 30, 2023 09:05
@lukarade lukarade marked this pull request as ready for review March 30, 2023 14:01
@lukarade
Copy link
Contributor Author

lukarade commented Mar 30, 2023

Like we discussed today, I want to close this PR, so it is easier to apply changes to the new branch without having to deal with merge conflicts afterwards. All requested changes will be applied on the new branch: https://github.com/Safe-DS/Library-Analyzer/tree/second-iteration-for-purity-analysis

@lars-reimann
Copy link
Member

I want to close this PR

Do you want the PR to be merged or closed without being merged?

@lukarade lukarade merged commit adf27ef into main Mar 30, 2023
@lukarade lukarade deleted the 5-data-model-for-purity-information branch March 30, 2023 15:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Data model for Purity-Information
2 participants