Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support placeholder queries that only request a subset of data #39

Merged
merged 15 commits into from
Jan 24, 2024

Conversation

WinPlay02
Copy link
Contributor

  • changed placeholder_query messages (VSCode to Runner) to allow optional window_begin and window_size fields (in addition to the placeholder name)
  • change validation to validate correctness of these fields
  • changed placeholder_value messages (Runner to VSCode) to include window_begin, window_size and window_max fields and windowed flag when querying only windows of data

Copy link

github-actions bot commented Jan 18, 2024

🦙 MegaLinter status: ✅ SUCCESS

Descriptor Linter Files Fixed Errors Elapsed time
✅ PYTHON black 3 0 0 0.7s
✅ PYTHON mypy 3 0 1.75s
✅ PYTHON ruff 3 0 0 0.03s
✅ REPOSITORY git_diff yes no 0.01s

See detailed report in MegaLinter reports
Set VALIDATE_ALL_CODEBASE: true in mega-linter.yml to validate all sources, not only the diff

MegaLinter is graciously provided by OX Security

Copy link

codecov bot commented Jan 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1bcad07) 100.00% compared to head (03e55ce) 100.00%.

Additional details and impacted files
@@            Coverage Diff            @@
##              main       #39   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           11        11           
  Lines          390       421   +31     
=========================================
+ Hits           390       421   +31     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@WinPlay02 WinPlay02 marked this pull request as ready for review January 22, 2024 02:29
@WinPlay02 WinPlay02 requested a review from a team as a code owner January 22, 2024 02:29
SmiteDeluxe
SmiteDeluxe previously approved these changes Jan 23, 2024
Copy link
Contributor

@SmiteDeluxe SmiteDeluxe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, although I am a bit out of touch with the runner anyway. The DSL changes are probably more relevant to me

lars-reimann
lars-reimann previously approved these changes Jan 23, 2024
@lars-reimann lars-reimann merged commit dae57dc into main Jan 24, 2024
7 checks passed
@lars-reimann lars-reimann deleted the windowed-placeholder-query branch January 24, 2024 09:21
lars-reimann pushed a commit that referenced this pull request Jan 26, 2024
## [0.5.0](v0.4.0...v0.5.0) (2024-01-26)

### Features

* added json serializer that encodes tables and images ([#29](#29)) ([054cca4](054cca4)), closes [#20](#20)
* Memoization ([#38](#38)) ([2a26b48](2a26b48))
* Replace flask with quart ([#43](#43)) ([5520b68](5520b68)), closes [#42](#42)
* support placeholder queries that only request a subset of data ([#39](#39)) ([dae57dc](dae57dc))
* update to safe-ds 0.17.1 + server refactor ([#37](#37)) ([1bcad07](1bcad07))

### Bug Fixes

* allow multiple connections to work with the runner ([#31](#31)) ([64685a3](64685a3))
@lars-reimann
Copy link
Member

🎉 This PR is included in version 0.5.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@lars-reimann lars-reimann added the released Included in a release label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released Included in a release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants