Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] Request for more actionable error messages #213

Closed
marlee114 opened this issue Jun 14, 2023 · 7 comments · Fixed by #214
Closed

[FEATURE] Request for more actionable error messages #213

marlee114 opened this issue Jun 14, 2023 · 7 comments · Fixed by #214
Assignees
@rohanshah18
Labels
App 💻 Issues/Pull Requests which update Drifty Application Code EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community feature ✨ New feature request or addition good first issue Good for newcomers
Milestone
Drifty v2.0.0

Comments

@marlee114
Copy link

Is your feature request related to a problem? Please describe.

When using the Drifty application, error messages displayed to the user do not provide much aid in helping them troubleshoot or understand what may be the problem with a certain download request.

Describe the solution you'd like.

I would like the application to provide more actionable error messages that are descriptive, and in plain english. As a result, the user may be able to fix a mistake in their request, or at least understand what may be causing the download to fail.

Screenshots

test11
test4-spy csv-file

Additional information

No response
@marlee114 marlee114 added App 💻 Issues/Pull Requests which update Drifty Application Code feature ✨ New feature request or addition labels Jun 14, 2023
@SaptarshiSarkar12
Copy link
Owner

Thank you @marlee114 for bringing up this issue! Yes, it will be better if more adequate details are displayed about the errors that the user has no idea of.
So, do you want to work on this issue?

@SaptarshiSarkar12
Copy link
Owner

Also, please check the latest code by running the application in an IDE (preferably IntelliJ Idea Community Edition).
NOTE : Please run Drifty_GUI file to start the GUI and Drifty_CLI file to run the CLI. You can find those java programs in the GUI and CLI directory under src/main directory.

@SaptarshiSarkar12 SaptarshiSarkar12 added help wanted Extra attention and support, and contributors are needed good first issue Good for newcomers EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community labels Jun 15, 2023
@rohanshah18
Copy link
Contributor

Can you assign this to me please?

@marlee114
Copy link
Author

Rohan can have it, if he wants

@marlee114
Copy link
Author

Also, please check the latest code by running the application in an IDE (preferably IntelliJ Idea Community Edition).
NOTE : Please run Drifty_GUI file to start the GUI and Drifty_CLI file to run the CLI. You can find those java programs in the GUI and CLI directory under src/main directory.

I ran it on the windows command line, but maybe on an IDE its different

@SaptarshiSarkar12
Copy link
Owner

Can you assign this to me please?

@rohanshah18 Yes 👍. You can work on it as @marlee114 has no problem.

@SaptarshiSarkar12 SaptarshiSarkar12 removed the help wanted Extra attention and support, and contributors are needed label Jun 16, 2023
@rohanshah18
Copy link
Contributor

Thanks @marlee114! I'll start working on this and have an update by weekend.

@rohanshah18 rohanshah18 mentioned this issue Jun 19, 2023
Merged
@SaptarshiSarkar12 SaptarshiSarkar12 linked a pull request Jun 22, 2023 that will close this issue
Added more details in error messages from Drifty App #214
Merged
SaptarshiSarkar12 added a commit that referenced this issue Jun 27, 2023
@rohanshah18 @SaptarshiSarkar12
Fix(App): Added more actionable error messages
0822df7 
Added more actionable error messages by @rohanshah18 via PR #214 closing issue #213.
---------

Co-authored-by: Rohan Shah <rohanshah@Rohans-MBP.home>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
SaptarshiSarkar12 added a commit that referenced this issue Jul 6, 2023
@rohanshah18 @SaptarshiSarkar12
Fix(App): Added more actionable error messages
78ad133 
Added more actionable error messages by @rohanshah18 via PR #214 closing issue #213.
---------

Co-authored-by: Rohan Shah <rohanshah@Rohans-MBP.home>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
SaptarshiSarkar12 added a commit that referenced this issue Jul 7, 2023
@rohanshah18 @SaptarshiSarkar12
Fix(App): Added more actionable error messages
cfdbceb 
Added more actionable error messages by @rohanshah18 via PR #214 closing issue #213.
---------

Co-authored-by: Rohan Shah <rohanshah@Rohans-MBP.home>
Co-authored-by: Saptarshi Sarkar <saptarshi.programmer@gmail.com>
@SaptarshiSarkar12 SaptarshiSarkar12 added this to the Drifty v2.0.0 milestone Aug 10, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 modified the milestone: Drifty v2.0.0 Sep 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rohanshah18 rohanshah18

Labels
App 💻 Issues/Pull Requests which update Drifty Application Code EddieHub:good-first-issue Label for good-first-issue finder made by EddieHub Community feature ✨ New feature request or addition good first issue Good for newcomers
Projects
Drifty
Status: Done
Milestone
Drifty v2.0.0
Development

Successfully merging a pull request may close this issue.

Added more details in error messages from Drifty App
3 participants
@rohanshah18 @marlee114 @SaptarshiSarkar12