Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added accurate color coding fill-in effect to social media icons in the footer. #137

Merged
merged 1 commit into from
Oct 22, 2022

Conversation

codedmachine111
Copy link
Contributor

Hello @SaptarshiSarkar12 . I have added a decent styling to the footer icons by adding a fill-in effect on hover with accurate color codes. Kindly review my PR.

@netlify
Copy link

netlify bot commented Oct 20, 2022

Deploy Preview for drifty ready!

Name Link
🔨 Latest commit d73a41a
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/6351a35ae20112000ab2065d
😎 Deploy Preview https://deploy-preview-137--drifty.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@SaptarshiSarkar12
Copy link
Owner

@codedmachine111 there are some performance issues, please check at https://pagespeed.web.dev

@codedmachine111
Copy link
Contributor Author

codedmachine111 commented Oct 21, 2022

Hello @SaptarshiSarkar12 . I looked into it and all i have to say is that i just changed the hover effect with some css (you can view my commits). Nothing major was changed. As per the website, the issues taking up most of the time are :-
Not Properly size images
5.1 s

I apologize, but i do not think my code has major changes to cause performance issues. Kindly review it again and i would love to change my code or add something new.Thankyou.

@SaptarshiSarkar12
Copy link
Owner

Hello @SaptarshiSarkar12 . I looked into it and all i have to say is that i just changed the hover effect with some css (you can view my commits). Nothing major was changed. As per the website, the issues taking up most of the time are :- Not Properly size images 5.1 s

I apologize, but i do not think my code has major changes to cause performance issues. Kindly review it again and i would love to change my code or add something new.Thankyou.

Ok @codedmachine111 . Please create an issue at first and link that to this PR.

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 . Thanks for contributing. Please leave a star on this project if you liked it. @codedmachine111 . Please create an issue although i am going to merge it.

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 06b8ad0 into SaptarshiSarkar12:master Oct 22, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 22, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
Added accurate color coding fill-in effect to social media icons in the footer.
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
Added accurate color coding fill-in effect to social media icons in the footer.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Enhancing the styling of social media icons in the footer.
2 participants