-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added accurate color coding fill-in effect to social media icons in the footer. #137
Added accurate color coding fill-in effect to social media icons in the footer. #137
Conversation
✅ Deploy Preview for drifty ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
@codedmachine111 there are some performance issues, please check at https://pagespeed.web.dev |
Hello @SaptarshiSarkar12 . I looked into it and all i have to say is that i just changed the hover effect with some css (you can view my commits). Nothing major was changed. As per the website, the issues taking up most of the time are :- I apologize, but i do not think my code has major changes to cause performance issues. Kindly review it again and i would love to change my code or add something new.Thankyou. |
Ok @codedmachine111 . Please create an issue at first and link that to this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 . Thanks for contributing. Please leave a star on this project if you liked it. @codedmachine111 . Please create an issue although i am going to merge it.
Added accurate color coding fill-in effect to social media icons in the footer.
Added accurate color coding fill-in effect to social media icons in the footer.
Hello @SaptarshiSarkar12 . I have added a decent styling to the footer icons by adding a fill-in effect on hover with accurate color codes. Kindly review my PR.