Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds See More option for releases to see release note #142

Merged
merged 10 commits into from
Oct 22, 2022

Conversation

redet-G
Copy link
Contributor

@redet-G redet-G commented Oct 22, 2022

No description provided.

@netlify
Copy link

netlify bot commented Oct 22, 2022

Deploy Preview for drifty ready!

Name Link
🔨 Latest commit cf061d3
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/63543eb277c5360009e4b7c8
😎 Deploy Preview https://deploy-preview-142--drifty.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@redet-G
Copy link
Contributor Author

redet-G commented Oct 22, 2022

#141

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Oct 22, 2022 that may be closed by this pull request
@SaptarshiSarkar12
Copy link
Owner

@redet-G the text goes out of the screen size and some part of the release notes is not rendered (Here you can add Show More option in case of lengthy release notes)

Screenshot_2022-10-22-21-54-57
Screenshot_2022-10-22-21-54-47

@SaptarshiSarkar12
Copy link
Owner

@redet-G Also change see More to Learn More

@redet-G
Copy link
Contributor Author

redet-G commented Oct 22, 2022

@SaptarshiSarkar12 That was a great catch.
I have fixed the width issues (e9708d0) and calculated the height dynamically (7548096).

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 That was a great catch. I have fixed the width issues (e9708d0) and calculated the height dynamically (7548096).

@redet-G Please align this part in the center of the screen.
image

@SaptarshiSarkar12
Copy link
Owner

@SaptarshiSarkar12 That was a great catch. I have fixed the width issues (e9708d0) and calculated the height dynamically (7548096).

@redet-G Please align this part in the center of the screen. image

I mean the text.

@redet-G
Copy link
Contributor Author

redet-G commented Oct 22, 2022

@SaptarshiSarkar12 like this
image

@SaptarshiSarkar12
Copy link
Owner

SaptarshiSarkar12 commented Oct 22, 2022

@redet-G Please fix this by aligning this text in the center.
image

@SaptarshiSarkar12
Copy link
Owner

Sorry @redet-G , closed this by mistake!

@SaptarshiSarkar12
Copy link
Owner

Please align the release notes in the center @redet-G !

@redet-G
Copy link
Contributor Author

redet-G commented Oct 22, 2022

It does not look great when the release note is centered.
image
After centering the whole thing
image

@SaptarshiSarkar12
Copy link
Owner

ok then @redet-G .

@redet-G
Copy link
Contributor Author

redet-G commented Oct 22, 2022

or We could center all none UL elements. Like this.
image

Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks for contributing 🚀 🚀.

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 5c4db05 into SaptarshiSarkar12:master Oct 22, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 22, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
@SaptarshiSarkar12 SaptarshiSarkar12 changed the title Adds See More option for releases to see release note #141 Adds See More option for releases to see release note Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
Adds See More option for releases to see release note #141
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
Adds See More option for releases to see release note #141
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Loading release note on demand on download section
2 participants