Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dark mode button UI improved. #95

Merged
merged 8 commits into from
Oct 9, 2022
Merged

Dark mode button UI improved. #95

merged 8 commits into from
Oct 9, 2022

Conversation

bhumika-1-3
Copy link
Contributor

No description provided.

@bhumika-1-3
Copy link
Contributor Author

image

ISSUE: BETTER UI FOR DARK MODE BUTTON

@SaptarshiSarkar12
Copy link
Owner

@bhumika-1-3 Can you please deploy these changes in your repo?

@SaptarshiSarkar12 SaptarshiSarkar12 linked an issue Oct 9, 2022 that may be closed by this pull request
[FEATURE] Better UI for the dark mode button #91
Closed
@bhumika-1-3
Copy link
Contributor Author

I am unable to deploy the folder. Can you plz try.

@SaptarshiSarkar12
Copy link
Owner

I am unable to deploy the folder. Can you plz try.

Please follow the later part of the discussions in this PR #74

@SaptarshiSarkar12
Copy link
Owner

I am unable to deploy the folder. Can you plz try.

Please follow the later part of the discussions in this PR #74

@bhumika-1-3

@bhumika-1-3
Copy link
Contributor Author

I have deployed as instructed can you check ? @SaptarshiSarkar12

@SaptarshiSarkar12
Copy link
Owner

@bhumika-1-3 You don't need to create "pages.yml", it's already present in your repo : https://github.com/bhumika-1-3/Drifty/blob/master/.github/workflows/pages.yml.

@SaptarshiSarkar12
Copy link
Owner

@bhumika-1-3 You don't need to create "pages.yml", it's already present in your repo : https://github.com/bhumika-1-3/Drifty/blob/master/.github/workflows/pages.yml.

You just need to go to settings>pages>and then follow the below pic -

image

@SaptarshiSarkar12
Copy link
Owner

@bhumika-1-3 You don't need to create "pages.yml", it's already present in your repo : https://github.com/bhumika-1-3/Drifty/blob/master/.github/workflows/pages.yml.

You just need to go to settings>pages>and then follow the below pic -

image

@bhumika-1-3 Then, your repo will be deployed at http://bhumika-1-3.github.io/Drifty

@bhumika-1-3
Copy link
Contributor Author

image

only this is showing

@SaptarshiSarkar12
Copy link
Owner

image

only this is showing

It's live at : https://bhumika-1-3.github.io/Drifty/

@SaptarshiSarkar12
Copy link
Owner

@bhumika-1-3 Please add the support of showing text - "Switch to Light Mode" when dark mode is enabled and vice versa.

Like this -

image

@bhumika-1-3
Copy link
Contributor Author

okay will do.

@bhumika-1-3
Copy link
Contributor Author

image

image

@SaptarshiSarkar12

@netlify
Copy link

netlify bot commented Oct 9, 2022 •
edited
Loading

✅ Deploy Preview for drifty ready!

Name Link
🔨 Latest commit 9530e85
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/6342d7be26059b0009a20aba
😎 Deploy Preview https://deploy-preview-95--drifty.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Oct 9, 2022

👷 Deploy Preview for drifty processing.

Name Link
🔨 Latest commit 9530e85
🔍 Latest deploy log https://app.netlify.com/sites/drifty/deploys/6342d7be26059b0009a20aba

@SaptarshiSarkar12
Copy link
Owner

Nice @bhumika-1-3 !

SaptarshiSarkar12
SaptarshiSarkar12 approved these changes Oct 9, 2022
View reviewed changes
Copy link
Owner

@SaptarshiSarkar12 SaptarshiSarkar12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍. Thanks For Contributing 🚀 🚀

@SaptarshiSarkar12 SaptarshiSarkar12 merged commit 328383e into SaptarshiSarkar12:master Oct 9, 2022
@SaptarshiSarkar12 SaptarshiSarkar12 added the hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest label Oct 9, 2022
@SaptarshiSarkar12
Copy link
Owner

@bhumika-1-3 Please leave a star on my repo if you liked my project.

@SaptarshiSarkar12 SaptarshiSarkar12 added feature ✨ New feature request or addition Website 🌐 Issues/Pull Requests regarding Website labels Mar 20, 2023
SaptarshiSarkar12 added a commit that referenced this pull request Jul 6, 2023
@SaptarshiSarkar12
Merge pull request #95 from bhumika-1-3/master
2529ecb 
Dark mode button UI improved.
SaptarshiSarkar12 added a commit that referenced this pull request Jul 7, 2023
@SaptarshiSarkar12
Merge pull request #95 from bhumika-1-3/master
037eaca 
Dark mode button UI improved.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SaptarshiSarkar12 SaptarshiSarkar12 SaptarshiSarkar12 approved these changes

Assignees
No one assigned
Labels
feature ✨ New feature request or addition hacktoberfest-accepted Accepted Pull Requests for Hacktoberfest Website 🌐 Issues/Pull Requests regarding Website
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[FEATURE] Better UI for the dark mode button
2 participants
@bhumika-1-3 @SaptarshiSarkar12