[RHCloud] Update configure_rhai_client registration

[ColeHiggins2]

Registering a host with insights client was failing.

After further investigation, It appears that we were are not actually syncing rhel 6 - 9 repos but instead "mocking" them to be enabled...which are needed for insights setup.

This process must have started failing during our update to global registration across components?

My solution to this is to simply move the registration portion of confiure_rhai_client to be executed AFTER we setup the correct "mock" repositories needed and packages installed.

The other option in my mind was to manually register insights after we setup the repos using
insights-client --register

But the first way allows us to register insights upon Satellite registration (which is the expected behavior)

[ColeHiggins2]

trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k 'test_positive_sync_inventory_status'

[Satellite-QE]

PRT Result

Build Number: 8801
Build Status: UNSTABLE
PRT Comment: pytest tests/foreman/cli/test_rhcloud_inventory.py -k test_positive_sync_inventory_status --external-logging
Test Result : ===== 5 passed, 16 deselected, 618 warnings, 1 error in 2447.09s (0:40:47) =====

[vsedmik]

Do you know what is the error in registration specifically?
I just wonder if it was failed insights-client installation during GR, which would explain why it works now when GR is done after client pre-installation.

Otherwise I agree to exercise the insights-client --register via GR rather than separately.

[Gauravtalreja1]

Can this be moved to below the registration to check if insights-client package is installed?
and it can be installed with yum when register=False>

[ColeHiggins2]

In this case, I think logically it should stay where it is... We need to make sure those packages are installed before we register

[Gauravtalreja1]

@ColeHiggins2 yes, but this step would be covered with setup_insights=register_insights when register=True, where this isn't required, but its required to install insights-client manually, when register=False, right?

[Gauravtalreja1]

Could you use the same PR to describe use of register_insights param here?

[ColeHiggins2]

its a setting when registering a client to a sat. You can set up insights during this process. This is true by default

[Gauravtalreja1]

@ColeHiggins2 yes, but I meant if it could be described in the function metadata, which it isn't

[ColeHiggins2]

Do you know what is the error in registration specifically? I just wonder if it was failed insights-client installation during GR, which would explain why it works now when GR is done after client pre-installation.

Otherwise I agree to exercise the insights-client --register via GR rather than separately.

I honestly dont know what changed between global registration and the prior. I was hoping to hear back from @shweta83 or @tpapaioa on this.

[tpapaioa]

The fix looks good to me. My only request is to update the method's name and docstring to remove references to rhai / red hat access insights, which is the old package name. configure_rhai_client could instead be configure_insights_client.

[ColeHiggins2]

trigger: test-robottelo
pytest: tests/foreman/cli/test_rhcloud_inventory.py -k 'test_positive_sync_inventory_status'

[Satellite-QE]

PRT Result

Build Number: 8860
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_rhcloud_inventory.py -k test_positive_sync_inventory_status --external-logging
Test Result : ========= 6 passed, 16 deselected, 706 warnings in 2645.36s (0:44:05) ==========

[sambible]

Would be nice to understand what changed here, but I don't think it's necessary, as this patch is logically sound.

[Gauravtalreja1]

@sambible There is no point merging the PRs if the threads are open and discussions are happening, especially if the code owners require Tier2 review. OR if you feel the feedback isn't necessary or non-blocking, at least you should comment on those threads.