[6.15.z] Fetch pre_upgrade data based on node properties #16552
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherrypick of PR: #16423
Problem Statement
During TFA I've seen several
post_upgrade
failures for "rhel_contenthost
-parametrized" upgrade scenario tests where the pre-data could not be fetched from thescenario_entities
file:The reason is that the pre-upgrade test names are now suffixed with
-ipv4
or-ipv6
so thescenario_entities
hold items like this:while this piece of code requires the exact param, which is just
rhel7
,rhel8
,rhel9
.Solution(?)
There are probably more than one solution and I'm not sure which one would be the best.
Initially I thought we could go regardless the
ipvX
suffix since I supposed the pipelines were separated (first commit).That's probably not a good solution when we start decorating tests with
['ipv4', 'ipv6']
explicitly, so I took the network type from the settings.Please let me know if there is a better place where to get that information from in scope of the
pre_upgrade_data
fixture.