Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[6.15.z] Remove CSV parser workaround #16554

Merged
merged 1 commit into from
Oct 3, 2024

Conversation

tpapaioa
Copy link
Contributor

@tpapaioa tpapaioa commented Oct 2, 2024

Problem Statement

A previous PR #15823 removed outdated code from robottelo's hammer CSV output handling. This PR removes the last workaround, now that the fix for https://projects.theforeman.org/issues/37264 is included in 6.15 with rubygem-hammer_cli_foreman_tasks-0.0.21-1.el8sat.noarch.

Solution

Remove the workaround that scans for non-CSV patterns in the output.

Related Issues

SAT-27296

@tpapaioa tpapaioa changed the base branch from master to 6.15.z October 2, 2024 17:04
@tpapaioa tpapaioa self-assigned this Oct 2, 2024
@tpapaioa tpapaioa added No-CherryPick PR doesnt need CherryPick to previous branches 6.15.z Introduced in or relating directly to Satellite 6.15 labels Oct 2, 2024
@tpapaioa
Copy link
Contributor Author

tpapaioa commented Oct 2, 2024

trigger: test-robottelo
pytest: tests/foreman/cli/test_host.py::test_positive_install_package_via_rex[rhel8-ipv4] tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_positive_run_packages_and_services_job[rhel8-ipv4]

@Satellite-QE
Copy link
Collaborator

PRT Result

Build Number: 8852
Build Status: SUCCESS
PRT Comment: pytest tests/foreman/cli/test_host.py::test_positive_install_package_via_rex[rhel8-ipv4] tests/foreman/cli/test_ldapauthsource.py::TestADAuthSource::test_positive_refresh_usergroup_with_ad[foobargroup] tests/foreman/cli/test_ansible.py::TestAnsibleREX::test_positive_run_packages_and_services_job[rhel8-ipv4] --external-logging
Test Result : ================= 3 passed, 118 warnings in 1086.15s (0:18:06) =================

@Satellite-QE Satellite-QE added the PRT-Passed Indicates that latest PRT run is passed for the PR label Oct 2, 2024
@tpapaioa tpapaioa marked this pull request as ready for review October 2, 2024 19:18
@tpapaioa tpapaioa requested a review from a team as a code owner October 2, 2024 19:18
@jyejare jyejare merged commit 2bec95c into SatelliteQE:6.15.z Oct 3, 2024
16 of 17 checks passed
@tpapaioa tpapaioa deleted the csv_fixes_615 branch October 3, 2024 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.15.z Introduced in or relating directly to Satellite 6.15 No-CherryPick PR doesnt need CherryPick to previous branches PRT-Passed Indicates that latest PRT run is passed for the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants