This repository has been archived by the owner on Sep 28, 2024. It is now read-only.
CompatHelper: bump compat for CUDA to 4, (keep existing compat) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
foldfelis
force-pushed
the
compathelper/new_version/2023-02-02-00-21-34-660-02466707078
branch
from
34c6855
to
54a6c41
Compare
Codecov Report
@@ Coverage Diff @@
## main #109 +/- ##
==========================================
- Coverage 90.44% 87.07% -3.38%
==========================================
Files 10 10
Lines 178 178
==========================================
- Hits 161 155 -6
- Misses 17 23 +6
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
|
@yuehhua @ChrisRackauckas can this be merged? Currently the CUDA v3 compat prevents that this packages can be used with current Flux releases. |
ChrisRackauckas
deleted the
compathelper/new_version/2023-02-02-00-21-34-660-02466707078
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request changes the compat entry for the
CUDApackage from3to3, 4.This keeps the compat entries for earlier versions.
Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.