Skip to content
This repository has been archived by the owner on Sep 28, 2024. It is now read-only.

Deeponet #39

Merged
merged 10 commits into from
Feb 27, 2022
Merged

Deeponet #39

merged 10 commits into from
Feb 27, 2022

Conversation

ba2tro
Copy link
Contributor

@ba2tro ba2tro commented Feb 24, 2022

Resolves #37. I have added the files for DeepONet implementation from OperatorLearning.jl and added tests for the architecture.

@ba2tro
Copy link
Contributor Author

ba2tro commented Feb 24, 2022

@foldfelis should I update the readme and docs as well?

@foldfelis
Copy link
Contributor

Hi @Abhishek-1Bhatt it would be great to have the docs and readme updated 😊

An import of Random was placed, although there was no use for it. Since it isn't in the deps, it would be best to remove it from here for now, so that the tests don't fail.
@ba2tro
Copy link
Contributor Author

ba2tro commented Feb 24, 2022

Great 😊, I'll start working on it.

@codecov
Copy link

codecov bot commented Feb 25, 2022

Codecov Report

Merging #39 (d3e58f1) into master (f47637f) will decrease coverage by 8.10%.
The diff coverage is 71.42%.

Impacted file tree graph

@@             Coverage Diff             @@
##            master      #39      +/-   ##
===========================================
- Coverage   100.00%   91.89%   -8.11%     
===========================================
  Files            2        5       +3     
  Lines           52       74      +22     
===========================================
+ Hits            52       68      +16     
- Misses           0        6       +6     
Impacted Files Coverage Δ
src/NeuralOperators.jl 100.00% <ø> (ø)
src/DeepONet.jl 60.00% <60.00%> (ø)
src/subnets.jl 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f47637f...d3e58f1. Read the comment docs.

@foldfelis
Copy link
Contributor

Hi @Abhishek-1Bhatt I didn't notice that there is a model training task inside the test 🤣 . I was wondering why the CI kept running for an hour. Is there another way to test DeepONet?

@ba2tro
Copy link
Contributor Author

ba2tro commented Feb 25, 2022

Oh😅, this was intended to be a regression test, just to sanity check that our model's training does not get deteriorated if we try out something new in the future. Indeed it doesn't make sense to train for 400 epochs here, I see that now : ) . One thing we can do is to reduce the no. of epochs to 100 or even lesser and then check against the error bound or would you like to have a different way of testing for it? @ChrisRackauckas might also have some suggestions regarding regression testing here.

@foldfelis
Copy link
Contributor

Usually, I only do the unit test and put the training tasks into the example folder. I will manually test the examples locally to make sure that things won't go wrong. I am looking for a more efficient way to test the robustness of the models as well.

@ba2tro
Copy link
Contributor Author

ba2tro commented Feb 25, 2022

That seems like a nice way to do it, we can transfer it to example/Burgers

@foldfelis
Copy link
Contributor

Feel free to add new examples and I will reorganize and refactor the project once the new featur is merged.

@ba2tro
Copy link
Contributor Author

ba2tro commented Feb 27, 2022

Removed an import of MAT.jl, it was causing the tests to fail😅

@foldfelis
Copy link
Contributor

Looks good to me 🎉

@foldfelis foldfelis merged commit 82b0465 into SciML:master Feb 27, 2022
@ba2tro ba2tro deleted the deeponet branch June 19, 2022 13:56
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Porting support for DeepONets from OperatorLearning.jl
2 participants