Skip to content

Commit

Permalink
split rating tests
Browse files Browse the repository at this point in the history
  • Loading branch information
pboettch committed Nov 15, 2023
1 parent 7670093 commit 66e9ba7
Showing 1 changed file with 24 additions and 20 deletions.
44 changes: 24 additions & 20 deletions tests/test_event.py
Original file line number Diff line number Diff line change
@@ -1,12 +1,12 @@
import datetime as dt
import re
import unittest
from ddt import ddt, data, unpack # type: ignore

from ddt import data, ddt, unpack # type: ignore

import tscat.orm_sqlalchemy
from tscat import create_event

import datetime as dt
import re


@ddt
class TestEvent(unittest.TestCase):
Expand Down Expand Up @@ -103,29 +103,33 @@ def test_constructor_with_dynamic_attribute_manual_access(self):
self.assertEqual(e.field_bool, True)
self.assertEqual(e.field_dt, dt_val)

def test_event_rating(self):
@data(
(None,),
(1,),
(5,),
)
@unpack
def test_event_valid_rating_values(self, value):
t1, t2 = dt.datetime.now(), dt.datetime.now() + dt.timedelta(days=1)

e = create_event(t1, t2, "Patrick")
self.assertEqual(e.rating, None)

e.rating = 1
self.assertEqual(e.rating, 1)
e.rating = value
self.assertEqual(e.rating, value)

e.rating = 5
self.assertEqual(e.rating, 5)
@data(
(-1,),
(0,),
(1.5,),
(11,),
)
@unpack
def test_event_invalid_rating_values(self, value):
t1, t2 = dt.datetime.now(), dt.datetime.now() + dt.timedelta(days=1)

e.rating = None
e = create_event(t1, t2, "Patrick")
self.assertEqual(e.rating, None)

with self.assertRaises(ValueError):
e.rating = -1

with self.assertRaises(ValueError):
e.rating = 0

with self.assertRaises(ValueError):
e.rating = 1.5

with self.assertRaises(ValueError):
e.rating = 11
e.rating = value

0 comments on commit 66e9ba7

Please sign in to comment.