Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure we backup the database before doing migration #60

Merged
merged 2 commits into from
Jun 8, 2024

Conversation

jeandet
Copy link
Member

@jeandet jeandet commented Jun 8, 2024

No description provided.

Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet requested a review from pboettch June 8, 2024 09:37
@jeandet jeandet added the enhancement New feature or request label Jun 8, 2024
Copy link

codecov bot commented Jun 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.84%. Comparing base (04a201d) to head (f74e8eb).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
+ Coverage   99.51%   99.84%   +0.32%     
==========================================
  Files          14       14              
  Lines        1858     1914      +56     
==========================================
+ Hits         1849     1911      +62     
+ Misses          9        3       -6     
Flag Coverage Δ
unittests 99.84% <100.00%> (+0.32%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jeandet jeandet force-pushed the backup_db_before_migration branch from 90778d9 to bd1400a Compare June 8, 2024 14:19
Copy link
Collaborator

@pboettch pboettch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

small typo change requested.

tscat/orm_sqlalchemy/__init__.py Outdated Show resolved Hide resolved
Signed-off-by: Alexis Jeandet <alexis.jeandet@member.fsf.org>
@jeandet jeandet force-pushed the backup_db_before_migration branch from de191a8 to f74e8eb Compare June 8, 2024 15:01
Copy link

sonarcloud bot commented Jun 8, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@pboettch pboettch self-requested a review June 8, 2024 15:39
@jeandet jeandet merged commit 5834854 into SciQLop:main Jun 8, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants