Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ENH: Allow a single geometry in add_geometries #1999

Merged
merged 1 commit into from
Jan 27, 2022

Conversation

greglucas
Copy link
Contributor

Allow single geometries to be added to a geoaxes, even though the method is plural. This will make it more user friendly to highlight single geometry objects without having to remember to make it an iterable list.

Closes #1303

@greglucas greglucas added this to the 0.21 milestone Jan 27, 2022
Allow single geometries to be added to a geoaxes, even though the
method is plural.
Copy link
Contributor

@dopplershift dopplershift left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems good. Test failures seem unrelated.

@greglucas greglucas merged commit 591b851 into SciTools:main Jan 27, 2022
@greglucas greglucas deleted the single-geom branch January 27, 2022 15:43
@greglucas
Copy link
Contributor Author

Yes, unfortunately I don't think there is much we can do about that docs failure :( We've had that one before... We really need to look into getting away from testing remote server connections as the ones we hit seem to be quite flaky.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Colouring countries
2 participants