MNT: Use pathlib throughout the codebase #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Dec 14, 2022
| @@ -24,6 +24,7 @@ | |||
| sys.exit(error) | |||
|
|
|||
|
|
|||
| from pathlib import Path | |||
There was a problem hiding this comment.
E402 module level import not at top of file
There was a problem hiding this comment.
Do we want to drop the Python 2 crutch and allow the imports to be at the top?
There was a problem hiding this comment.
I think it's be nice to remove, but maybe we should wait until we have wheels? Then it's generally a given if you're building from source, you need to be certain everything's good.
There was a problem hiding this comment.
Yes, that seems reasonable. I'm not sure when we'll get wheels here... Still a few PRs needed even if/when we remove GEOS.
greglucas
force-pushed
the
use-pathlib
branch
2 times, most recently
from
c1b9ae4
to
4e39b7f
Compare
greglucas
force-pushed
the
use-pathlib
branch
2 times, most recently
from
40e3cdc
to
db4e536
Compare
QuLogic
reviewed
Feb 24, 2023
greglucas
force-pushed
the
use-pathlib
branch
from
db4e536
to
f1c9bd2
Compare
stickler-ci
reviewed
Feb 26, 2023
stickler-ci
reviewed
Feb 26, 2023
QuLogic
reviewed
Feb 27, 2023
greglucas
force-pushed
the
use-pathlib
branch
from
e4d1ab0
to
eee02fc
Compare
stickler-ci
reviewed
Feb 28, 2023
Change os.path usages to pathlib.Path()
greglucas
force-pushed
the
use-pathlib
branch
from
eee02fc
to
707961b
Compare
stickler-ci
reviewed
Feb 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change
os.pathusages topathlib.Path()