TST/FIX: Test for instance rather than string in class representation #2130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stickler-ci
reviewed
Jan 26, 2023
Matplotlib has merged SubplotBase into AxesBase now, which makes the class string representation here GeoAxes now, even though we are still an _instance_ of GeoAxesSubplot
greglucas
force-pushed
the
mpl37-subplot-class
branch
from
42be528
to
6b4572b
Compare
dopplershift
approved these changes
Jan 26, 2023
|
Failures look unrelated, but need to be fixed at some point. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing with the pre-release MPL 3.7 wheel has added one new test failure.
Matplotlib has merged SubplotBase into AxesBase now, which makes the class string representation here GeoAxes now, even though we are still an instance of
GeoAxesSubplot.xref: matplotlib/matplotlib#23573
Rationale
Implications