Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update to cell_method parsing #6083

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update to cell_method parsing #6083

wants to merge 4 commits into from

Commits on Jul 29, 2024

  1. Provided error message for malformed cell_method attribute

    @ukmo-ccbunney
    ukmo-ccbunney committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    995bfe9 View commit details
    Browse the repository at this point in the history

  2. Made cell_method pattern matching more lenient w.r.t. space after c… 

    …olon separator
    @ukmo-ccbunney
    ukmo-ccbunney committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    5325653 View commit details
    Browse the repository at this point in the history

  3. Changed cell_methods regex slightly to fix failures in unit tests. 

    Also added new unit test to check cell_methods with:
  1. Name only (no colon and method)
  2. Not space between colon separator and method.
    @ukmo-ccbunney
    ukmo-ccbunney committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    55414a9 View commit details
    Browse the repository at this point in the history

  4. [pre-commit.ci] auto fixes from pre-commit.com hooks 

    for more information, see https://pre-commit.ci
    @pre-commit-ci @ukmo-ccbunney
    pre-commit-ci[bot] authored and ukmo-ccbunney committed Jul 29, 2024
    Configuration menu
    Copy the full SHA
    41d4c79 View commit details
    Browse the repository at this point in the history