Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Update Video/Dockerfile with based image ffmpeg:6.0-alpine #1981

Merged
merged 2 commits into from
Oct 25, 2023
Merged

feat: Update Video/Dockerfile with based image ffmpeg:6.0-alpine #1981

merged 2 commits into from
Oct 25, 2023

Conversation

VietND96
Copy link
Member

@VietND96 VietND96 commented Oct 25, 2023

Thanks for contributing to the Docker-Selenium project!
A PR well described will help maintainers to quickly review and merge it

Before submitting your PR, please check our contributing guidelines, applied for this repository.
Avoid large PRs, help reviewers by making them as simple and short as possible.

Description

Update based image to jrottenberg/ffmpeg:6.0-alpine

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • I have read the contributing document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@CLAassistant
Copy link

CLAassistant commented Oct 25, 2023

CLA assistant check
All committers have signed the CLA.

@diemol
Copy link
Member

diemol commented Oct 25, 2023

Oh, I merged #1881, which causes conflicts here. Could you please solve them so I can merge?

@VietND96
Copy link
Member Author

Ok, let me resolve conflicts and retest after #1881

Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 marked this pull request as draft October 25, 2023 12:06
@VietND96 VietND96 marked this pull request as ready for review October 25, 2023 12:17
@VietND96
Copy link
Member Author

Hi @diemol ,
I already resolved conflicts. I also built locally the chart after #1881 and tested it with the image in part of this PR. It works fine.
Kindly review and feedback. Thanks!

Copy link
Member

@diemol diemol left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @VietND96!

@diemol diemol merged commit 60ad27e into SeleniumHQ:trunk Oct 25, 2023
4 checks passed
diemol pushed a commit that referenced this pull request Oct 27, 2023
Signed-off-by: Viet Nguyen Duc <nguyenducviet4496@gmail.com>
@VietND96 VietND96 changed the title Update Video/Dockerfile with based image ffmpeg:6.0-alpine feat: Update Video/Dockerfile with based image ffmpeg:6.0-alpine Dec 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants