You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a brief explanation for the make set_containerd_image_store command to provide more context
Consider adding a brief explanation about the purpose of the make set_containerd_image_store command to provide more context for users who may not be familiar with it.
```bash
+# This command enables the containerd image store feature in Docker Engine
make set_containerd_image_store
- [ ] **Apply this suggestion** <!-- /improve --apply_suggestion=0 -->
<details><summary>Suggestion importance[1-10]: 7</summary>
Why: Adding a comment to explain the command in the code block enhances understanding for users unfamiliar with it, improving documentation quality.
</details></details></td><td align=center>7
</td></tr><tr><td>
<details><summary>Add an explanation about the CircleCI status badge to inform users what it represents</summary>
___
**Consider adding a brief explanation about the significance of the CircleCI status badge to <br>inform users what it represents.**
[README.md [152-153]](https://github.com/SeleniumHQ/docker-selenium/pull/2300/files#diff-b335630551682c19a781afebcf4d07bf978fb1f8ac04c6bf87428ed5106870f5R152-R153)
```diff
[![CircleCI](https://dl.circleci.com/status-badge/img/gh/SeleniumHQ/docker-selenium/tree/trunk.svg?style=svg)](https://dl.circleci.com/status-badge/redirect/gh/SeleniumHQ/docker-selenium/tree/trunk)
+This badge indicates the current build status of the project on CircleCI.
Apply this suggestion
Suggestion importance[1-10]: 7
Why: Providing context about the CircleCI status badge helps users understand its significance, enhancing the documentation's informativeness.
7
Readability
Rephrase the note about Firefox availability for better readability
To improve readability, consider rephrasing the note about Firefox availability to make it clearer that the ARM64 version will differ from the AMD64 version until the stable release.
-The Firefox version in ARM64 will be different with the AMD64 until the stable release is available. The Firefox (node and standalone) images are available in multi-arch.+The Firefox version for ARM64 will differ from the AMD64 version until the stable release is available. The Firefox (node and standalone) images are available in multi-arch.
Apply this suggestion
Suggestion importance[1-10]: 5
Why: The suggested rephrasing slightly improves readability but does not significantly impact the overall understanding or accuracy of the information.
5
Rephrase the note about running AMD64 images under emulation on ARM64 platforms for better clarity
To improve clarity, consider rephrasing the note about running AMD64 images under emulation on ARM64 platforms.
-Running an AMD64 image under emulation on an ARM64 platform is not recommended due to performance and [stability issues](https://github.com/SeleniumHQ/docker-selenium/issues/2298).+Running AMD64 images under emulation on ARM64 platforms is not recommended due to performance and [stability issues](https://github.com/SeleniumHQ/docker-selenium/issues/2298).
Apply this suggestion
Suggestion importance[1-10]: 5
Why: The rephrasing slightly improves clarity but does not significantly change the original meaning or impact of the statement.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
User description
Description
Motivation and Context
From #2298 it was not clear that running AMD64 images under Apple Silicon was not supported.
Types of changes
Checklist
PR Type
Documentation
Description
Changes walkthrough 📝
README.md
Update README for ARM64 images and browser support
README.md