Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tooltips to disabled buttons #572

Open
nombrekeff opened this issue Feb 7, 2019 · 4 comments
Open

Add tooltips to disabled buttons #572

nombrekeff opened this issue Feb 7, 2019 · 4 comments

Comments

@nombrekeff
Copy link

🚀 Feature Proposal

Add tooltips to disabled buttons, I find it's a bit weird not knowing what a button does when disabled.

Description

I'm refering to this buttons, if they are disabled they don't show the tooltip, and I think it would be nice
to know what the button does so you can take action.
image

PD:*

I don't know if this is by design or just something not thought of...

@zewa666
Copy link
Contributor

zewa666 commented Mar 8, 2019

This is an issue with react-tooltip the library used for custom tooltips

@corevo
Copy link
Member

corevo commented Mar 11, 2019

I've reverted some of the changes made since it regressed some css, I'll look into it once I have the time to do so.

@zewa666
Copy link
Contributor

zewa666 commented Mar 11, 2019

Ouch, if you can give me some pointers about what went wrong I can dig in as well. Sorry for causing troubles.

@corevo
Copy link
Member

corevo commented Mar 11, 2019

Mostly around the test component and the toolbar, it relies on the button being a direct child c63f88b.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants