fix(Button): render labeled as a <button> (#597)

* Update Button.js fix switch button to div * add test button labeled icon * Simplified test * add space
Semantic-Org · Oct 3, 2016 · b22e138 · b22e138
1 parent 3087ad1
commit b22e138
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/src/elements/Button/Button.js b/src/elements/Button/Button.js
@@ -60,7 +60,7 @@ function Button(props) {
 
   const rest = getUnhandledProps(Button, props)
   const ElementType = getElementType(Button, props, () => {
-    if (label || labeled || attached) return 'div'
+    if (label || attached) return 'div'
   })
   const tabIndex = ElementType === 'div' ? 0 : undefined
 

diff --git a/test/specs/elements/Button/Button-test.js b/test/specs/elements/Button/Button-test.js
@@ -126,4 +126,11 @@ describe('Button', () => {
       wrapper.children().at(1).should.match('.ui.label')
     })
   })
+
+  describe('labeled', () => {
+    it('renders as a button', () => {
+      const wrapper = shallow(<Button labeled />)
+      wrapper.should.have.tagName('button')
+    })
+  })
 })