feat(Popup): add debug logs

Semantic-Org · Nov 14, 2016 · e95e98e · e95e98e
1 parent ece3893
commit e95e98e
Showing 1 changed file with 16 additions and 3 deletions.
diff --git a/src/modules/Popup/Popup.js b/src/modules/Popup/Popup.js
@@ -5,6 +5,7 @@ import {
   getElementType,
   getUnhandledProps,
   isBrowser,
+  makeDebugger,
   META,
   SUI,
   useKeyOnly,
@@ -14,6 +15,8 @@ import Portal from '../../addons/Portal'
 import PopupContent from './PopupContent'
 import PopupHeader from './PopupHeader'
 
+const debug = makeDebugger('popup')
+
 const _meta = {
   name: 'Popup',
   type: META.TYPES.MODULE,
@@ -234,13 +237,16 @@ export default class Popup extends Component {
         portalProps.closeOnTriggerBlur = true
         break
 
-      default:  // default to hover
+      case 'hover':
         portalProps.openOnTriggerMouseOver = true
         portalProps.closeOnTriggerMouseLeave = true
         // Taken from SUI: https://git.io/vPmCm
         portalProps.mouseLeaveDelay = 70
         portalProps.mouseOverDelay = 50
         break
+
+      default:
+        break
     }
 
     if (hoverable) {
@@ -258,18 +264,21 @@ export default class Popup extends Component {
   }
 
   handleClose = (e) => {
+    debug('handleClose()')
     const { onClose } = this.props
     if (onClose) onClose(e, this.props)
   }
 
   handleOpen = (e) => {
+    debug('handleOpen()')
     this.coords = e.currentTarget.getBoundingClientRect()
 
     const { onOpen } = this.props
     if (onOpen) onOpen(e, this.props)
   }
 
   handlePortalMount = (e) => {
+    debug('handlePortalMount()')
     if (this.props.hideOnScroll) {
       window.addEventListener('scroll', this.hideOnScroll)
     }
@@ -279,11 +288,13 @@ export default class Popup extends Component {
   }
 
   handlePortalUnmount = (e) => {
+    debug('handlePortalUnmount()')
     const { onUnmount } = this.props
     if (onUnmount) onUnmount(e, this.props)
   }
 
   popupMounted = (ref) => {
+    debug('popupMounted()')
     this.popupCoords = ref ? ref.getBoundingClientRect() : null
     this.setPopupStyle()
   }
@@ -333,10 +344,12 @@ export default class Popup extends Component {
       </ElementType>
     )
 
+    const mergedPortalProps = { ...this.getPortalProps(), ...portalProps }
+    debug('portal props:', mergedPortalProps)
+
     return (
       <Portal
-        {...this.getPortalProps()}
-        {...portalProps}
+        {...mergedPortalProps}
         trigger={trigger}
         onClose={this.handleClose}
         onMount={this.handlePortalMount}