Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disabled Button with Label leaves Label enabled #1026

Closed
levithomason opened this issue Dec 13, 2016 · 3 comments · Fixed by #1035
Closed

Disabled Button with Label leaves Label enabled #1026

levithomason opened this issue Dec 13, 2016 · 3 comments · Fixed by #1035
Labels
bug good first issue help wanted

Comments

@levithomason
Copy link
Member

Steps

  1. Create a disabled Button with label.

Expected Result

Both the button and the label should be disabled.

Actual Result

Only the button is disabled, the label is not.

This is because the disabled prop is passed to the button child. It should instead be used to create a disabled className for the wrapping div.

Version

v0.62.1

Testcase

http://codepen.io/levithomason/pen/pNxwMb
luski added a commit to luski/Semantic-UI-React that referenced this issue Dec 15, 2016
@luski
fix(Button): Disabled Button with Label leaves Label enabled (Semanti…
e92f4fb 
…c-Org#1026)
luski added a commit to luski/Semantic-UI-React that referenced this issue Dec 15, 2016
@luski
fix(Button): Disabled Button with Label leaves Label enabled (Semanti…
6b59245 
…c-Org#1026)
@luski luski mentioned this issue Dec 16, 2016
Merged
luski added a commit to luski/Semantic-UI-React that referenced this issue Dec 16, 2016
@luski
fix(Button): Disabled Button with Label gets duplicate opacity (Seman…
5d2e5c4 
…tic-Org#1026)
luski added a commit to luski/Semantic-UI-React that referenced this issue Dec 16, 2016
@luski
fix(Button): Fixed lint error (Semantic-Org#1026)
575005b
luski added a commit to luski/Semantic-UI-React that referenced this issue Dec 17, 2016
@luski
fix(Button): Test cases for the fixed part (Semantic-Org#1026)
0ed4c2d
@tarang9211
Copy link
Contributor

@levithomason can we close this issue if it's fixed?

levithomason pushed a commit to luski/Semantic-UI-React that referenced this issue Jan 24, 2017
@luski @levithomason
fix(Button): Disabled Button with Label leaves Label enabled (Semanti…
716976e 
…c-Org#1026)
levithomason pushed a commit to luski/Semantic-UI-React that referenced this issue Jan 24, 2017
@luski @levithomason
fix(Button): Disabled Button with Label gets duplicate opacity (Seman…
9cc8bfa 
…tic-Org#1026)
levithomason pushed a commit to luski/Semantic-UI-React that referenced this issue Jan 24, 2017
@luski @levithomason
fix(Button): Fixed lint error (Semantic-Org#1026)
775b465
levithomason pushed a commit to luski/Semantic-UI-React that referenced this issue Jan 24, 2017
@luski @levithomason
fix(Button): Test cases for the fixed part (Semantic-Org#1026)
7eb628c
@levithomason
Copy link
Member Author

We can once the PR is merged, #1035.

@tarang9211
Copy link
Contributor

Yea, sorry about this! I meant to comment on another (already closed) issue!

luski added a commit to luski/Semantic-UI-React that referenced this issue Feb 2, 2017
@luski
fix(Button) Disable tab stop for the disabled labeled button (Semanti…
611bee7 
…c-Org#1026)
levithomason pushed a commit that referenced this issue Feb 12, 2017
@luski @levithomason
fix(Button): Disabled Button with Label leaves Label enabled (#1035)
4a321ec 
* fix(Button): Disabled Button with Label leaves Label enabled (#1026)

* fix(Button): Disabled Button with Label gets duplicate opacity (#1026)

* fix(Button): Fixed lint error (#1026)

* fix(Button): Test cases for the fixed part (#1026)

* rebase to master

* fix(Button) Disable tab stop for the disabled labeled button (#1026)
harel pushed a commit to harel/Semantic-UI-React that referenced this issue Feb 18, 2017
@luski @harel
fix(Button): Disabled Button with Label leaves Label enabled (Semanti…
6ff1f5a 
…c-Org#1035)

* fix(Button): Disabled Button with Label leaves Label enabled (Semantic-Org#1026)

* fix(Button): Disabled Button with Label gets duplicate opacity (Semantic-Org#1026)

* fix(Button): Fixed lint error (Semantic-Org#1026)

* fix(Button): Test cases for the fixed part (Semantic-Org#1026)

* rebase to master

* fix(Button) Disable tab stop for the disabled labeled button (Semantic-Org#1026)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(Button): Disabled Button with Label leaves Label enabled luski/Semantic-UI-React
2 participants
@levithomason @tarang9211