Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Typings: Add Comments from Source Files #1075

Closed
cschmidli opened this issue Dec 22, 2016 · 2 comments
Closed

Typings: Add Comments from Source Files #1075

cschmidli opened this issue Dec 22, 2016 · 2 comments
Labels
enhancement good first issue help wanted

Comments

@cschmidli
Copy link
Contributor

I saw you have a lot of comments in the js source files for the components etc, which is great!

Any reason why we shouldn't add them to the typings file too? It improves the IDE experience quite a bit.
@levithomason
Copy link
Member

Absolutely, PRs welcome!

@cschmidli
Copy link
Contributor Author

ok, i'll fix one

@cschmidli cschmidli mentioned this issue Dec 23, 2016
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement good first issue help wanted
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@cschmidli @levithomason