fix(typings): Add comments from source and fix minor inconsistencies #1084
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.83% (diff: 100%)@@ master #1084 diff @@
==========================================
Files 873 873
Lines 4827 4827
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 4626 4626
Misses 201 201
Partials 0 0
|
|
A scan here looks good. I'll merge this and we'll address any issues if they arise. Thanks much! |
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for ticket: #1075
Fixes:
Additional comment:
there are still no typings for some components and the form typings seem incomplete, but I'll create a separate ticket for that.
would be great if someone can quickly review the changes and apply the updated typings in a bigger project to see whether it spawns unintended errors.