Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<Loader /> Component #180

Closed
levithomason opened this issue Mar 16, 2016 · 4 comments
Closed

<Loader /> Component #180

levithomason opened this issue Mar 16, 2016 · 4 comments

Comments

@levithomason
Copy link
Member

http://semantic-ui.com/elements/loader.html

@layershifter
Copy link
Member

API

Loader can be basic and with text.

<div class="ui loader"></div>
<div class="ui text loader">Loading</div>
<Loader />
<Loader text='Loading' />

Loader has following states: active, disabled and indeterminate.

<div class="ui active loader"></div>
<div class="ui disabled loader"></div>
<div class="ui indeterminate text loader">Preparing Files</div>
<Loader active />
<Loader disabled />
<Loader indeterminate text='Preparing Files' />

Loader has following variations: inline, centered inline, inverted and size.

<div class="ui active inline loader"></div>
<div class="ui active centered inline loader"></div>
<div class="ui active inverted loader"></div>
<div class="ui mini text loader">Loading</div>
<Loader active inline />
<Loader active centered inline />
<Loader active centered-inline />
<Loader size='mini' text='Loading' />

Did I miss any? 😄

@levithomason
Copy link
Member Author

levithomason commented Jul 7, 2016

Woop! Nice job here, we're ready to start this one considering these comments:

Text

Let's also support mutuallyExclusive children. This will allow users to put more complicated markup in the loader:

<Loader>
  <p>Taking a while?</p>
  <Button size='mini' icon='refresh'>Reload</Button>
</Loader>
<div class="ui mini text loader">
  <p>Taking a while?</p>
  <button class="ui mini button">
    <i class="refresh icon" />
    Reload
  </button>
</div>

Note the presence of children should also add the text class.

Inline

The API for this one looks like this. Use the keyOrValueAndKey() propUtil in the cx buildup to extract the classes.

<Loader inline />
<Loader inline='centered' />

Size

Just clarifying it does not support big or massive sizes.

@layershifter
Copy link
Member

Thanks for feedback 😄 I'll make PR soon

layershifter pushed a commit to layershifter/stardust that referenced this issue Jul 8, 2016
layershifter pushed a commit to layershifter/stardust that referenced this issue Jul 8, 2016
levithomason pushed a commit that referenced this issue Jul 11, 2016
* (feat) Loader #180

* (fix) Loader #180

* (feat) Loader docs #328

* (fix) README.md #328

* (fix) Loader docs #328

* (fix) Loader #328

* (fix) Loader #328
@layershifter
Copy link
Member

It seems, issue may be closed 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants