Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Divider to v1 API #262

Closed
levithomason opened this issue Jun 21, 2016 · 4 comments
Closed

Update Divider to v1 API #262

levithomason opened this issue Jun 21, 2016 · 4 comments

Comments

@levithomason
Copy link
Member

levithomason commented Jun 21, 2016

From the linked issue where this convo started:

The Divider element is a pretty minimal component. That might be a good start. The docs are already in place for the Divider as well, so you'll have something to reference as you develop the API. You'll be looking to update src/elements/Divider/Divider.js and update docs at docs/app/Examples/elements/Divider.

The new API should look like this. These examples follow the docs at http://semantic-ui.com/elements/divider.

Types

Divider

<Divider />
<div class="ui divider"></div>

Vertical Divider

<Divider vertical />
<div class="ui vertical divider"></div>

Horizontal Divider

<Divider horizontal />
<div class="ui horizontal divider"></div>

Variations

Inverted

<Divider inverted />
<div class="ui inverted divider"></div>

Fitted

<Divider fitted />
<div class="ui fitted divider"></div>

Hidden

<Divider hidden />
<div class="ui hidden divider"></div>

Section

<Divider section />
<div class="ui section divider"></div>

Clearing

<Divider clearing />
<div class="ui clearing divider"></div>
@levithomason
Copy link
Member Author

/cc @jamiehill

@levithomason
Copy link
Member Author

Fixed in #268, big thanks!

@jhchill666
Copy link
Contributor

I you want to spec up any of the other 'need helps' cc me and I can pick
up in next couple of days

Levi Thomason wrote:

Closed #262 https://github.com/TechnologyAdvice/stardust/issues/262.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
https://github.com/TechnologyAdvice/stardust/issues/262#event-700649087,

or mute the thread
https://github.com/notifications/unsubscribe/AAWHsy5a3DzlidIkYaDJCFcL8YGLcRt_ks5qOVNSgaJpZM4I6_8b.

@levithomason
Copy link
Member Author

@jamiehill I've created a list of components over at #269. We'll use that to keep track of which components need update. Thanks much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants