Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Error trying to run in webpack cannot resolve module 'utils/Meta' #340

Closed
tslater opened this issue Jul 19, 2016 · 8 comments · Fixed by #341
Closed

Error trying to run in webpack cannot resolve module 'utils/Meta' #340

tslater opened this issue Jul 19, 2016 · 8 comments · Fixed by #341
Labels

Comments

@tslater
Copy link
Contributor

tslater commented Jul 19, 2016

I get the following error:

ERROR in ./~/stardust/dist/collections/Breadcrumb/Breadcrumb.js
Module not found: Error: Cannot resolve module 'utils/Meta' in /path/to/project/node_modules/stardust/dist/collections/Breadcrumb
 @ ./~/stardust/dist/collections/Breadcrumb/Breadcrumb.js 21:12-33

It is fixed when I make this change:

var _Meta = require('utils/Meta'); --> var _Meta = require('../../utils/Meta');

Is that a proper fix?

@levithomason
Copy link
Member

Indeed, though this should be made to the src/collections/Breadcrumb/Breadcrumb.js directory.

We use webpack resolve to resolve root paths for the doc site. Somehow, this one slipped through into the library. All library paths in src should be relative.

@levithomason
Copy link
Member

Would you like make a PR?

@tslater
Copy link
Contributor Author

tslater commented Jul 19, 2016

I can try. I'll start working through the contributing guidelines.

@levithomason
Copy link
Member

levithomason commented Jul 19, 2016

Thanks. In this case you can fork this repo, make a commit to Breadcrumb in src that updates the path, then open a PR against master.

layershifter pushed a commit to layershifter/stardust that referenced this issue Jul 19, 2016
@levithomason
Copy link
Member

@tslater note @layershifter has submitted a pr ^

@tslater
Copy link
Contributor Author

tslater commented Jul 19, 2016

Opps. I guess I was too late on that one. Should I delete mine? It looks like there was a doc that needed updating too.
#342

levithomason pushed a commit that referenced this issue Jul 19, 2016
* fix(Breadcrumb) Fix issue #340

* fix(Breadcrumb) Fix import order
@tslater tslater changed the title Error trying to run in webpack annot resolve module 'utils/Meta' Error trying to run in webpack cannot resolve module 'utils/Meta' Jul 19, 2016
@levithomason
Copy link
Member

I merged both since they updated different parts. Thanks!

@tslater
Copy link
Contributor Author

tslater commented Jul 19, 2016

Awesome. Glad I could help in some small way. Awesome work on the package!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants