Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Item.Image doesn't honor size prop #746

Closed
clemensw opened this issue Oct 25, 2016 · 2 comments
Closed

Item.Image doesn't honor size prop #746

clemensw opened this issue Oct 25, 2016 · 2 comments
Labels
bug

Comments

@clemensw
Copy link
Contributor

clemensw commented Oct 25, 2016 •
edited
Loading

The wrapped Image produced by Item.Image doesn't seem to honor the size prop.

Item.Image renders as a wrapped image with ui=false. Looking at http://semantic-ui.com/views/item.html#image seems to indicate that their wrapped image uses

.

Indeed adding ui=true to the Image produced by Item.Image seems to resolve the size issue.
Update: there is an explicit test ensuring ui=false, so perhaps there's something I don't understand about how semantic is supposed to work.
clemensw added a commit to clemensw/stardust that referenced this issue Oct 25, 2016
@clemensw
fix(Item.Image): Add ui class to wrapped Image to enable size propert…
32053f9 
…y to work

* Resolves Semantic-Org#746
* Reverses an explicit test for ui=false, so needs review.
* Renders similar to the example at http://semantic-ui.com/views/item.html#image
* Images now render left aligned and sized.
@clemensw clemensw mentioned this issue Oct 25, 2016
Merged
clemensw added a commit to clemensw/stardust that referenced this issue Oct 25, 2016
@clemensw
fix(Item.Image): Add ui class to wrapped Image to enable size propert…
df4dc82 
…y to work

* Resolves Semantic-Org#746
* Reverses an explicit test for ui=false, so needs review.
* Renders similar to the example at http://semantic-ui.com/views/item.html#image
* Images now render left aligned and sized.
clemensw added a commit to clemensw/stardust that referenced this issue Oct 28, 2016
@clemensw
fix(Item.Image): Add ui class to wrapped Image to enable size propert…
21d1515 
…y to work

* Resolves Semantic-Org#746
* Add ui class only for sized images
* Renders similar to the example at http://semantic-ui.com/views/item.html#image
* Images now render left aligned and sized.
clemensw added a commit to clemensw/stardust that referenced this issue Oct 28, 2016
@clemensw
fix(Item.Image): Add ui class to wrapped Image to enable size propert…
3f0533c 
…y to work

* Resolves Semantic-Org#746
* Add ui class only for sized images
* Renders similar to the example at http://semantic-ui.com/views/item.html#image
* Images now render left aligned and sized.
@Rex90
Copy link

Rex90 commented Jan 7, 2018

I dont believe this is fixed when the item.group is unstackable the image prop is not honoured

@Semantic-Org Semantic-Org locked as resolved and limited conversation to collaborators Feb 14, 2018
@levithomason
Copy link
Member

Please open a new issue with a complete report. We are happy to help.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@clemensw @levithomason @Rex90 @layershifter