-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add doc examples for color, size, and inverted Statistic Groups #974
Comments
@levithomason im looking to start contributing to this repo! would this be a good one to pick up? |
Absolutely. You can reference the existing docs in |
what exactly does this issue entail? |
All the examples featured on react.semantic-ui.com live in This issue was opened as a reminder that we need to add examples showing usage of the Statistic Group's |
Awesome, I'll get started on it today! |
@levithomason On the live site, I do see examples of Also, do I have appropriate access rights? Github says my fork is 9 commits behind. I tried to |
@jcarbo @levithomason I pushed a commit to my forked repo. Is this what you're getting at? |
Hey guys!
Could you give me some feedback on the Github comments?
Thanks!
Tarang
Regards
-Tarang Hirani
…On Sun, Dec 18, 2016 at 1:55 AM, Levi Thomason ***@***.***> wrote:
All the examples featured on react.semantic-ui.com live in
/docs/app/Examples. We show usage examples for all features of all our
components. The Statistic component was updated to have new features,
however, the docs have not been updated to show these new features.
This issue was opened as a reminder that we need to add examples showing
usage of the Statistic Group's color, size, and inverted props.
Currently, there are no examples showing these props for this component.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub
<#974 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AFmqGdlsTGeO5LotFlwuG3PNAc--DNWzks5rJEVKgaJpZM4LBn9b>
.
|
These are only for the individual Statistic component. We need color, size, and inverted examples for the
This repo is open source so anyone can pull from it. My guess is that your remote may be using ssh and you do not have ssh keys setup. Try:
If the url for
This is just about right! We'd like to use a separate example file for each example. Reference the individual |
Give me an hour or two and I'll have to ready! |
@levithomason created a PR. does this look better? created a file for each statistic group prop type. |
Thanks, let's move future convo over to that PR. I'll get a review as soon as I am able. |
This issue was fixed #1058. Closing for housekeeping |
@jcarbo just added
color
,size
, andinverted
support to theStatisticGroup
in #972. We should add doc site examples for these as well.We currently only show regular groups and evenly divided groups.
The text was updated successfully, but these errors were encountered: