Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add doc examples for color, size, and inverted Statistic Groups #974

Closed
levithomason opened this issue Dec 1, 2016 · 13 comments
Closed

Comments

@levithomason
Copy link
Member

@jcarbo just added color, size, and inverted support to the StatisticGroup in #972. We should add doc site examples for these as well.

We currently only show regular groups and evenly divided groups.

@tarang9211
Copy link
Contributor

@levithomason im looking to start contributing to this repo! would this be a good one to pick up?

@levithomason
Copy link
Member Author

levithomason commented Dec 17, 2016

Absolutely. You can reference the existing docs in /docs/app/examples/views/Statistic. Our docs follow the layout of the core docs at www.semantic-ui.com.

@tarang9211
Copy link
Contributor

what exactly does this issue entail?

@levithomason
Copy link
Member Author

All the examples featured on react.semantic-ui.com live in /docs/app/Examples. We show usage examples for all features of all our components. The Statistic component was updated to have new features, however, the docs have not been updated to show these new features.

This issue was opened as a reminder that we need to add examples showing usage of the Statistic Group's color, size, and inverted props. Currently, there are no examples showing these props for this component.

@tarang9211
Copy link
Contributor

Awesome, I'll get started on it today!

@tarang9211
Copy link
Contributor

tarang9211 commented Dec 18, 2016

@levithomason On the live site, I do see examples of color, size, and inverted props. They seem to correlate to the js files here https://github.com/Semantic-Org/Semantic-UI-React/tree/master/docs/app/Examples/views/Statistic/Variations

Also, do I have appropriate access rights? Github says my fork is 9 commits behind. I tried to git pull upstream master and it complained about inappropriate access rights.

@tarang9211
Copy link
Contributor

tarang9211 commented Dec 18, 2016

@jcarbo @levithomason I pushed a commit to my forked repo. Is this what you're getting at?
tarang9211@6c4df63

@tarang9211
Copy link
Contributor

tarang9211 commented Dec 19, 2016 via email

@levithomason
Copy link
Member Author

On the live site, I do see examples of color, size, and inverted props. They seem to correlate to the js files here https://github.com/Semantic-Org/Semantic-UI-React/tree/master/docs/app/Examples/views/Statistic/Variations

These are only for the individual Statistic component. We need color, size, and inverted examples for the <Statistic.Group /> component as well.

Also, do I have appropriate access rights? Github says my fork is 9 commits behind. I tried to git pull upstream master and it complained about inappropriate access rights.

This repo is open source so anyone can pull from it. My guess is that your remote may be using ssh and you do not have ssh keys setup. Try:

git remote -v

If the url for Semantic-UI-React.git begins with git@github.com then it is trying to use ssh. Either change your remote url to use https or setup ssh.

I pushed a commit to my forked repo. Is this what you're getting at?
tarang9211/Semantic-UI-React@6c4df63

This is just about right! We'd like to use a separate example file for each example. Reference the individual <Statistic /> examples and note how there is a different example file for each prop.

@tarang9211
Copy link
Contributor

Give me an hour or two and I'll have to ready!

@tarang9211
Copy link
Contributor

tarang9211 commented Dec 19, 2016

@levithomason created a PR. does this look better? created a file for each statistic group prop type.

#1058

@levithomason
Copy link
Member Author

Thanks, let's move future convo over to that PR. I'll get a review as soon as I am able.

@layershifter
Copy link
Member

This issue was fixed #1058. Closing for housekeeping

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants