Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/divider component #103

Merged
merged 7 commits into from
Nov 9, 2015
Merged

Feature/divider component #103

merged 7 commits into from
Nov 9, 2015

Conversation

kyleturco
Copy link
Contributor

Add a <Divider /> component and examples for the divider. (Note: currently failing the Wercker test as a result of the Babel update)

</div>
);
}
}
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does SD have a <Column> component? I used regular <div> and set the className to column in this example. We do need the columns though to get the proper formatting to show the vertical dividers

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, comments on this above before seeing your comment. Yep, just add Grid, Column to the import from stardust. Like other components, they include all the necessary base classes so you only need to add modifier classes (like three column relaxed to the <Grid />).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Roger that, both Column and Grid work 👍

@kyleturco kyleturco mentioned this pull request Nov 2, 2015
import DividerTypesExamples from './Types/DividerTypesExamples';
import DividerVariationsExamples from './Variations/DividerVariationsExamples';

export default class ButtonExamples extends Component {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Class name >.<

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh no, it never stops

@levithomason
Copy link
Member

After updating the one class name and using Grid and Column components, 🚢 !

kyleturco added a commit that referenced this pull request Nov 9, 2015
@kyleturco kyleturco merged commit b250670 into master Nov 9, 2015
@kyleturco kyleturco deleted the feature/divider-component branch November 9, 2015 18:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants