feat(TextArea): add autoHeight prop
#1083
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 95.84% (diff: 100%)@@ master #1083 diff @@
==========================================
Files 873 874 +1
Lines 4827 4835 +8
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
+ Hits 4626 4634 +8
Misses 201 201
Partials 0 0
|
luski
changed the title
|
I have no idea how to write tests checking if height of the textarea element changed. Any clues? |
|
Thanks for getting this going. I've refactored it a bit, adding docs and tests. LMK if anything looks out of place. I'll get a final review on this and merge once tests pass and you sign off on my updates. |
|
Also, can you please update the PR description so it closes the issue when merged? Docs here. |
|
Looks great, thanks. |
|
Cool, thanks. There seems to be a 1px rendering difference on CI than locally. I'll try to fix this. The comment will need to be in the main description of the PR to close the issue 👍 |
luski
changed the title
levithomason
changed the title
autoHeight prop
|
Released in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #982
Tested on Chrome and Firefox. I'll provide test cases in further commit in the nearest future