Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Portal): fix several event related behaviors #1273

Merged
merged 8 commits into from
Feb 2, 2017

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Feb 2, 2017

Fixes #1271 Do not steal focus on portal close
Fixes #1251 Do not stop propagation of events
Fixes #1076 Popups in Modals open in the correct position

This PR also:

  • fixes the mountNode=null bug in for the Modal
  • adds Modal prop closeOnDimmerClick
  • keeps a Portal open when blurring the trigger and focusing the Portal

@codecov-io
Copy link

codecov-io commented Feb 2, 2017

Codecov Report

Merging #1273 into master will increase coverage by <.01%.

@@            Coverage Diff             @@
##           master    #1273      +/-   ##
==========================================
+ Coverage   95.91%   95.92%   +<.01%     
==========================================
  Files         882      883       +1     
  Lines        4916     4927      +11     
==========================================
+ Hits         4715     4726      +11     
  Misses        201      201
Impacted Files Coverage Δ
...mples/modules/Dimmer/States/DimmerExampleActive.js 100% <ø> (ø)
...modules/Dimmer/Variations/DimmerExampleBlurring.js 50% <ø> (ø)
...amples/modules/Dimmer/Usage/DimmerExampleLoader.js 50% <ø> (ø)
...Dimmer/Variations/DimmerExampleBlurringInverted.js 50% <ø> (ø)
...modules/Dimmer/Variations/DimmerExampleInverted.js 50% <ø> (ø)
...mples/modules/Dimmer/Types/DimmerExampleContent.js 50% <ø> (ø)
...amples/modules/Dimmer/Types/DimmerExampleDimmer.js 50% <ø> (ø)
src/elements/Label/Label.js 100% <ø> (ø)
...amples/modules/Dimmer/Usage/DimmerExampleEvents.js 60% <ø> (ø)
...s/modules/Dimmer/Variations/DimmerExampleSimple.js 100% <ø> (ø)
... and 5 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8ce2f48...0f9dbe8. Read the comment docs.

@levithomason levithomason changed the title fix(Portal): do not tamper with events fix(Portal): fix several event related behaviors Feb 2, 2017
@levithomason levithomason merged commit cd65079 into master Feb 2, 2017
@levithomason levithomason deleted the fix/popup-trigger-click branch February 2, 2017 09:01
@levithomason
Copy link
Member Author

Released in semantic-ui-react@0.64.7.

harel pushed a commit to harel/Semantic-UI-React that referenced this pull request Feb 18, 2017
fix(Portal): fix several event related behaviors
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants