-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
style(mixed): update typings for usage with UMD #1427
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1427 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 141 141
Lines 2371 2371
=======================================
Hits 2365 2365
Misses 6 6 Continue to review full report at Codecov.
|
9e0f5b0
to
2a5d586
Compare
Agreed on the extra reviewers here. I'm not sure about exporting a single namespace versus individual exports. |
Perhaps @czb could test this out as he is requesting it. @dennari and @asvetliakov are also superb TS users and may have opinions here. |
Needs rebase after #1467. |
Fixed. |
PR was merged, I've need make rebase and actualize this PR. |
I want to close this for housekeeping. I don't see there any feedback from users while changes in this PR looks very ugly. I'm glad to see some feedback, possible it can be done more elegant. |
Agreed, we can always revisit this but I would like to clean up the open issues and PR's as much as possible. |
Fixes #1392.