chore(package): use prop-types package #1576
Conversation
package.json
Outdated
| @@ -56,7 +56,8 @@ | |||
| "babel-runtime": "^6.22.0", | |||
| "classnames": "^2.1.5", | |||
| "debug": "^2.6.3", | |||
| "lodash": "^4.17.2" | |||
| "lodash": "^4.17.2", | |||
| "prop-types": "^15.5.0" | |||
There was a problem hiding this comment.
I'm not sure about this, however, I'm followed recommendation there.
There was a problem hiding this comment.
Looks good, however, let's update to the latest:
Note: there are known issues in versions before 15.5.7 so we recommend using it as the minimal version.
There was a problem hiding this comment.
Updated to 15.5.7 👍
Codecov Report
@@ Coverage Diff @@
## master #1576 +/- ##
=======================================
Coverage 99.74% 99.74%
=======================================
Files 141 141
Lines 2384 2384
=======================================
Hits 2378 2378
Misses 6 6
Continue to review full report at Codecov.
|
layershifter
force-pushed
the
chore/react-proptypes
branch
from
7501080
to
78928fd
Compare
webpack.umd.config.js
Outdated
| @@ -13,6 +13,7 @@ const webpackUMDConfig = { | |||
| [pkg.name]: paths.src('umd.js'), | |||
| }, | |||
| externals: { | |||
| 'prop-types': 'PropTypes', | |||
There was a problem hiding this comment.
I believe per their instructions we should bundle propTypes with the code as a dependency. Otherwise, users will also have to make it globally available. I'll update this.
Just as a heads up, the Codepen is powered by the UMD build as well so any UMD changes also require updates there.
|
Released in |
Fixes #1564.
Ref.