fix(Input): add handling of input's ref #1581
Conversation
layershifter
force-pushed
the
fix/input-ref
branch
from
cb0e4cf
to
2857c18
Compare
src/elements/Input/Input.js
Outdated
| return createHTMLInput(child, { | ||
| defaultProps: htmlInputProps, | ||
| overrideProps: this.handleInputOverrides, | ||
| }) |
There was a problem hiding this comment.
Use factory instead of cloneElement
Codecov Report
@@ Coverage Diff @@
## master #1581 +/- ##
==========================================
+ Coverage 99.74% 99.74% +<.01%
==========================================
Files 141 141
Lines 2381 2384 +3
==========================================
+ Hits 2375 2378 +3
Misses 6 6
Continue to review full report at Codecov.
|
| const ref = sandbox.spy() | ||
| const wrapper = mount(<Input><input ref={ref} /></Input>) | ||
|
|
||
| // ref.should.have.been.calledOnce() |
There was a problem hiding this comment.
@levithomason I can't get this test working, can you take a look?
There was a problem hiding this comment.
Refs are not passed through props. React makes them undefined. We'll have to accept the ref on a different prop name, or, update factories to include refs in the overrides. We should probably use a different prop name, such as, inputRef.
There was a problem hiding this comment.
I've reverted back to cloneElement and updated handling of ref, also updated tests now everything works as expected. @levithomason thanks for the point to right direction
|
Released in |
Fixes #1536.