Support Form settings and callback props #165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
| } | ||
| const FormSpecifyingValidationRulesExample = (props) => ( | ||
| <Form className='segment' fields={fields} onSuccess={() => false}> |
There was a problem hiding this comment.
Use function form example component. Pulls deprecated form settings prop into individual props (fields, onSuccess).
| deprecate.props(this, { | ||
| settings: 'Use a separate prop for each setting.', | ||
| }) | ||
| } |
There was a problem hiding this comment.
Deprecated settings prop.
| onSuccess: PropTypes.func, | ||
| onFailure: PropTypes.func, | ||
| fields: PropTypes.object, | ||
| } |
There was a problem hiding this comment.
This is the pattern we are using for separating plugin props from component props. There is a utility to pick this.props for only plugin props, useful when calling refresh on the plugin. There's also a util for omitting plugin props, useful when spreading user props or doing other component prop checks.
|
See comment on practicalities and 🎸 |
levithomason
added a commit
that referenced
this pull request
Feb 11, 2016
Support Form settings and callback props
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Form props are not passed to settings (prevent submit) #160, handling form plugin props.
Adds deprecate utility to warn users of upcoming deprecations: