Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Dropdown): fix compatibility with IE #1667

Merged
merged 1 commit into from
May 13, 2017
Merged

Conversation

layershifter
Copy link
Member

Fixes #1315.

@codecov-io
Copy link

codecov-io commented May 10, 2017

Codecov Report

Merging #1667 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1667      +/-   ##
==========================================
+ Coverage   99.75%   99.75%   +<.01%     
==========================================
  Files         141      141              
  Lines        2408     2410       +2     
==========================================
+ Hits         2402     2404       +2     
  Misses          6        6
Impacted Files Coverage Δ
src/modules/Dropdown/Dropdown.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a9e8870...0e5191f. Read the comment docs.

@levithomason
Copy link
Member

@cattermo does this PR resolve your issue?

@cattermo
Copy link

It works!

Sorry for the delay, I thought I could npm install the branch from github directly but couldn't get it to work (corporate firewall...). Ended up copypasting the new code right into node_modules which proved working fine for testing purpuse.

@levithomason levithomason merged commit f05ab54 into master May 13, 2017
@levithomason levithomason deleted the fix/dropdown-in-ie branch May 13, 2017 18:55
@levithomason
Copy link
Member

Thanks for the testing and report @cattermo.

@levithomason
Copy link
Member

Released in semantic-ui-react@0.68.4.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants