feat(Search): noResultsMessage prop can be a node #1683
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1683 +/- ##
=======================================
Coverage 99.75% 99.75%
=======================================
Files 141 141
Lines 2410 2410
=======================================
Hits 2404 2404
Misses 6 6
Continue to review full report at Codecov.
|
src/modules/Search/Search.js
Outdated
| noResultsMessage: PropTypes.oneOfType([ | ||
| PropTypes.node, | ||
| PropTypes.object, | ||
| ]), |
There was a problem hiding this comment.
I believe this should just be PropTypes.node only. PropTypes.node includes any renderable value: string, number, element, or an array (or fragment) of any of these. However, objects are not renderable.
Let's also update the typings in Search.d.ts to reflect the type change as well.
There was a problem hiding this comment.
PropTypes.node includes any renderable value: string, number, element, or an array (or fragment) of any of these.
Didn't know about it. Thanks for useful information.
Made the necessary changes.
layershifter
added
ready for review
and removed
needs author feedback
ready for review
labels
src/modules/Search/Search.d.ts
Outdated
| @@ -30,7 +30,7 @@ export interface SearchProps { | |||
| noResultsDescription?: string; | |||
There was a problem hiding this comment.
@b0gok Thanks for a PR. I think that we need make same changes for noResultsDescription.
There was a problem hiding this comment.
@layershifter Should I add specific test for case when noResultsDescription isn't a string?
|
Thank you for the PR and updates! |
|
Released in |
PR for this issue #1664