Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Card component #202

Closed
wants to merge 2 commits into from
Closed

Add Card component #202

wants to merge 2 commits into from

Conversation

eanplatter
Copy link
Contributor

@eanplatter eanplatter commented Mar 18, 2016 •
edited by levithomason
Loading

Under Construction

Building the card.

@eanplatter eanplatter mentioned this pull request Mar 18, 2016
Closed
@eanplatter
Copy link
Contributor Author

Fixes: #186

@eanplatter eanplatter closed this Apr 4, 2016
@eanplatter eanplatter deleted the feature/card branch April 4, 2016 16:47
@levithomason levithomason restored the feature/card branch May 31, 2016 14:29
@levithomason levithomason deleted the feature/card branch May 31, 2016 14:30
@levithomason levithomason restored the feature/card branch May 31, 2016 14:30
@eanplatter eanplatter reopened this May 31, 2016
@levithomason levithomason changed the title UNDER CONSTRUCTION Add Card component May 31, 2016
@levithomason
Copy link
Member

I've rebased this PR to the latest master for you. I also added our basic commonTests, see here. I've added the .only() call to the Card-test.js as well so they are the only the tests that run.

It's been a while since you've hacked on this, so I'd blow away and reinstall node modules. You should then be able to run npm run test:watch and see only the common card tests. This should get you going as there are many well defined tests to get passing:

image

Cheers!

@eanplatter
Copy link
Contributor Author

🍂 sounds good man! Thanks!

@levithomason
Copy link
Member

Yo @eanplatter, I know you've been busy. Thanks to @jamiehill and a few others we're getting a lot of momentum. If we come up on this component, shall we ping you or hop on it?

Let me know what your plans are. Thanks.

@levithomason
Copy link
Member

Bump. Noted the new CONTRIBUTING.md docs. We need to spec out this component's API.

@eanplatter
Copy link
Contributor Author

@levithomason I'd be great to pair on this one of these evenings! I'd like to get a feel for the workflow so I can make contributions whenever I've got time, I've been doing react native lately so my need for stardust hasn't been as present, but as soon as I move back to web stuff I'll be using it.

@levithomason
Copy link
Member

I'm game for some pairing for sure. Busy tonight with 3SC, but hit me up on Slack to get a time set.

@athurman
Copy link
Contributor

Closing in light of #387

@athurman athurman closed this Aug 11, 2016
@levithomason levithomason deleted the feature/card branch August 13, 2016 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eanplatter @levithomason @athurman