Use enzyme in all tests #244
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| } | ||
|
|
||
| static defaultProps = { | ||
| abortLabel: 'Cancel', | ||
| confirmLabel: 'Yes', | ||
| ref: 'modal', |
There was a problem hiding this comment.
There is no reason to set an internal access only ref name via props. Anyway, it was not used.
levithomason
force-pushed
the
feature/remove-render-tree
branch
from
fe3c73f
to
d3cb50f
Compare
24 tasks
levithomason
force-pushed
the
feature/remove-render-tree
branch
from
d3cb50f
to
821407d
Compare
|
👻 , nothing really jumping out to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test removes our old
RenderTreetesting util in favor ofenzyme. The remaining tests using it were updated. Some missing tests were added. Very minimal component refactoring was made as well.shallowrendering was used everywhere possible. No test refactoring was done except that necessary to convert the old RenderTree syntax to the new enzyme.