Setup coverage #245
Merged
Setup coverage #245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| ] | ||
| ], | ||
| "env": { | ||
| "development": { |
There was a problem hiding this comment.
Moved all babel config into babelrc. The development section was previously in the loader query.
levithomason
force-pushed
the
feature/coverage
branch
from
1290666
to
3cdacd3
Compare
| @@ -45,7 +53,7 @@ module.exports = (karmaConfig) => { | |||
| ], | |||
| }, | |||
| plugins: [ | |||
| new webpack.DefinePlugin(config.compiler_globals), | |||
| ...webpackConfig.plugins, | |||
There was a problem hiding this comment.
Plugins are conditionally set in webpack config, use all available plugins.
levithomason
force-pushed
the
feature/coverage
branch
from
3cdacd3
to
f7dc0b6
Compare
| @@ -51,6 +51,7 @@ | |||
| "babel-core": "^6.5.2", | |||
| "babel-eslint": "^6.0.4", | |||
| "babel-loader": "^6.2.0", | |||
| "babel-plugin-__coverage__": "^0.111111.11", | |||
There was a problem hiding this comment.
Lol, is that version for real?
There was a problem hiding this comment.
Yea, I wish this said "babel-plugin-coverage": "^0.1.1". Some other folks are pushing for a "normal" 1.0 release as well on this issue.
|
👻 |
24 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up coverage reporting and fixes some test issues.
npm testHTML Coverage Report