Fix getComponentDocInfo docPath on windows #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levithomason
force-pushed
the
feature/fix-windows-docpath
branch
from
44ee360
to
8ac307f
Compare
|
/cc @davezuko @joshuazmiller |
Current coverage is 88.32%
|
|
👻 -- will be curious to see what this resolves in regard to the original issue. |
|
If not, this would have also been an issue. Then this is at least one of the problems. His docgenInfo.json keys look like this: "C:\\Users\\Joshua\\Dropbox\\GitHub\\stardust\\src\\addons\\Confirm\\Confirm.js": {}There would never be a match on that ^ using the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #304. This PR removes the
/in the path check logic. On Windows this is a\.