Remove _meta.library #380
Merged
Remove _meta.library #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 92.87% (diff: 100%)@@ master #380 diff @@
==========================================
Files 63 63
Lines 828 828
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 769 769
Misses 59 59
Partials 0 0
|
| @@ -28,7 +28,7 @@ export default class ComponentDescription extends Component { | |||
| renderSemanticDocsLink = () => { | |||
| const { _meta } = this.props | |||
|
|
|||
| if (!META.isSemanticUI(_meta)) return null | |||
| if (META.isAddon(_meta)) return null | |||
There was a problem hiding this comment.
isSemanticUI and isStardust is now determined by whether or not a component is an addon type. All other types are SUI core.
| const childClassName = c.prop('className') | ||
| if (childClassName) childClassName.should.not.contain('sd-') | ||
| }) | ||
| }) |
There was a problem hiding this comment.
Taking this opportunity to remove the sd-* className test now that all components have removed that className.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This repo will soon transfer to
Semantic-UI-React. When that happens, there will be no more "Stardust".All components will be under one library, SUI-React. This PR removes the
_meta.librarykey in preparation for this transfer.