Fix baseHref, refactor config and build #385
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| # | ||
| # 'npm run clean' runs rm -rf on all lines in this file. | ||
| # | ||
|
|
levithomason
force-pushed
the
chore/build-cleanup
branch
from
4330dc6
to
d60087a
Compare
Current coverage is 93.23% (diff: 100%)@@ master #385 diff @@
==========================================
Files 64 64
Lines 872 872
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 813 813
Misses 59 59
Partials 0 0
|
levithomason
force-pushed
the
chore/build-cleanup
branch
from
d60087a
to
18ac375
Compare
| compiler_lint: argv.lint !== false, | ||
| compiler_quiet: false, | ||
| compiler_output_path: paths.base(config.dir_docs_dist), | ||
| compiler_public_path: __BASE__, | ||
| compiler_public_path: __BASE__ || '/', |
There was a problem hiding this comment.
Removed the /config directory and 5 files of complexity in favor of 4 lines of conditionals in a single file. This caught duplicates and unused config as well.
|
👻 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The base href on the doc site was recently updated. In local dev, the anchor links are broken as they resolve to absolute urls. This PR addresses that.
In the way of this was some config/build cleanup and simplification.