fix(Dropdown): skip select item on blur when closed #508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is 98.68% (diff: 100%)@@ master #508 diff @@
==========================================
Files 102 102
Lines 1520 1520
Methods 0 0
Messages 0 0
Branches 0 0
==========================================
Hits 1500 1500
Misses 20 20
Partials 0 0
|
|
Released in |
|
Thanks, the fix works great! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #504
The Dropdown method
selectHighlightedItem()is called on blur. This method should only continue if the Dropdown is open.This PR adds the open logic to prevent duplicate calls to onChange. Without this, onChange is called on item click and again when the Dropdown is blurred.