Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(docs): replace react-highlighjs with react-ace #525

Merged
merged 1 commit into from
Sep 22, 2016

Conversation

levithomason
Copy link
Member

@levithomason levithomason commented Sep 22, 2016

This PR replaces react-highlight with react-ace. Fixes a number of things:

  • sets us up for having code editors in the docs (feat(docs): add component explorer #427)
  • resolves the intermittent build failures due to autoit (a react-highlight dep)
  • fixes JSX syntax highlighting
  • added an "active" style to code examples that are showing their code

Before

image

After

image

@codecov-io
Copy link

codecov-io commented Sep 22, 2016

Current coverage is 98.74% (diff: 100%)

Merging #525 into master will not change coverage

@@             master       #525   diff @@
==========================================
  Files           107        107          
  Lines          1754       1754          
  Methods           0          0          
  Messages          0          0          
  Branches          0          0          
==========================================
  Hits           1732       1732          
  Misses           22         22          
  Partials          0          0          

Powered by Codecov. Last update eb77509...b3848b4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants